win,src: fix GetModuleHandle for libnode.dll #3139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
force-pushed
the
mefi-libnode-fix
branch
from
3997d1a to
ad152bf
Compare
StefanStojanovic
force-pushed
the
mefi-libnode-fix
branch
from
a2ab0b8 to
53579c1
Compare
|
I've tried few different variations of a fix, and even running the action without any changes. Windows test jobs always to fail. Because of that, I do not think failures are caused by my changes. |
lukekarrys
approved these changes
Apr 1, 2025
|
I think the failing Windows tests in this PR were fixed by #3145. I think this can land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the description in the linked issue, this should fix the problem. There is no strong reason for making a change like this (and for example not using
GetModuleHandleAorL"libnode.dll"). This is the onlyGetModuleHandlecall in the entire project, so if someone thinks other approaches are better, let me know and I'll change it.Fixes: #3126
Refs: #2834