Skip to content

Normalize win32 library names #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Normalize win32 library names #3189

wants to merge 2 commits into from

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Jul 22, 2025

Checklist
  • npm install && npm run lint && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

I ran into this cross-compiling on a case-sensitive file-system. The official sdk includes this file:

VC/Tools/MSVC/14.44.35207/lib/x64/delayimp.lib

which does not have any casing. For simplicity, its easiest to list libraries with lower case names.

StefanStojanovic
StefanStojanovic approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues with this as long as all of the checks pass.

@cclauss
Copy link
Contributor

cclauss commented Jul 24, 2025

The failing Windows 2019 test is removed in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees
No one assigned
Labels
Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmm1 @cclauss @StefanStojanovic