This repository was archived by the owner on Feb 1, 2022. It is now read-only.
chore: align message with Node.js standard #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js uses (or will use) _Ctrl+C_ with no spaces. To unify the messages from inspect with other messages from the REPL and elsewhere, make that change in node-inspect too.
2 tasks
jkrems
approved these changes
Sep 21, 2020
|
Is there a timeline for getting this back into node? Or is it a "when convenient"? |
When convenient. |
Meaning: When convenient for you and other node-inspect maintainers. If you'd rather have it get into Node.js sooner than later, I'm happy to do whatever I can to make that easier if there's anything that's an obstacle. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js uses (or will use) Ctrl+C with no spaces. To unify the
messages from inspect with other messages from the REPL and elsewhere,
make that change in node-inspect too.