This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Updates to TypedArrays to match spec. #4442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Althought it is not used externally by node, it is needed by upstream and Plask.
This effectively reverts:
commit 1444801
Author: Aaron Jacobs <[email protected]>
Date: Thu Mar 15 13:26:35 2012 +1100
typed arrays: unexport SizeOfArrayElementForType()
It isn't used anywhere else, so made it an implementation detail in
v8_typed_array.cc.
When Mikael Bourges-Sevenier added support for Uint8ClampedArray, the new type was not added to SizeOfArrayElementForType.
This seems to have been added as a result of misreading the spec, there is no get() method, only a getter (which the spec names get()), but this is actually the [] operator. There are many webkit tests that explicitly test for the fact that the get() method is abscent. Remove it to conform to the spec.
It seems that like get(), set(index, val) was added as a misreading of the spec.
There are only two set() methods defined in the spec:
void set(TypedArray array, optional unsigned long offset)
void set(type[] array, optional unsigned long offset)
The set(index, val) is handled by the []= operator.
Additionally updated a few exception error strings to match WebKit.
|
Are the last 2 commits the relevant ones? |
|
Yes, sorry, I can make a clean branch if it helps. There are now 4 relevant commits (although it could be broken into 2 pull requests if you want). The ones of interest are removing get() and set(), and then the other are some cast changes (no code change) and some changes to exception messages to match WebKit. This is because I am running the WebKit tests. Once these changes are in (which gets us pretty much passing all of the tests), there is one more bugfix I have for when we are compiled 32-bit, and then I will make sure the tests pass for both 32 and 64-bit version of Node. |
|
I'm afraid the patches no longer apply. Dean, can you rebase them against master and submit them as a new PR? I promise I'll review them quickly. :-) |
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs/node#5179 Reviewed-By: Rich Trott <[email protected]> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs/node#5179 Reviewed-By: Rich Trott <[email protected]> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 18, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs/node#5179 Reviewed-By: Rich Trott <[email protected]> Fixes: nodejs/node#3635
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Mar 9, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs/node#5179 Reviewed-By: Rich Trott <[email protected]> Fixes: nodejs/node#3635
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These again are a few effective reverts of previous changes by Mikael Bourges-Sevenier to the TypedArrays code. I believe it was caused by a misreading of the spec, where get() and set() methods are defined as getters/setters ([] and []= operators). By removing these and updating a few exception strings the TypedArray implementation now fully passes the following related WebKit tests:
array-buffer-crash.html
array-buffer-view-crash-when-reassigned.html
array-buffer-view-crash.html
array-constructor.html
array-get-and-set-method-removal.html
array-get-out-of-bounds.html
array-override-set.html
array-set-invalid-arguments.html
array-set-out-of-bounds.html
array-set-with-offset.html
array-setters.html
array-unit-tests.html
dfg-float32array.js
dfg-int16array.js
dfg-int32array-overflow-values.js
dfg-int32array.js
dfg-int8array.js
dfg-uint16array.js
dfg-uint32array-overflow-values.js
dfg-uint32array.js
dfg-uint8array.js
dfg-uint8clampedarray.js