-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
Closed
Labels
discussIssues opened for discussions and feedbacks.Issues opened for discussions and feedbacks.errorsIssues and PRs related to JavaScript errors originated in Node.js core.Issues and PRs related to JavaScript errors originated in Node.js core.whatwg-urlIssues and PRs related to the WHATWG URL implementation.Issues and PRs related to the WHATWG URL implementation.
Description
Just realized according to the spec the errors thrown from our WHATWG URL implementation should be ECMAScript error objects, but internal/errors.js
provides errors subclassing those error classes, so does that mean our WHATWG URL implementation cannot be migrated to this new error system, or do we have a way to work around that?
cc @nodejs/url
domenic
Metadata
Metadata
Assignees
Labels
discussIssues opened for discussions and feedbacks.Issues opened for discussions and feedbacks.errorsIssues and PRs related to JavaScript errors originated in Node.js core.Issues and PRs related to JavaScript errors originated in Node.js core.whatwg-urlIssues and PRs related to the WHATWG URL implementation.Issues and PRs related to the WHATWG URL implementation.