Skip to content

benchmark, http, test: test/sequential/test-benchmark-http.js is incomplete #12903

@vsemozhetbyt

Description

@vsemozhetbyt
  • Version: 8.0.0 nightly 2017 05 07
  • Platform: Windows 7 x64
  • Subsystem: benchmark, http, test

benchmark/http/_chunky_http_client.js is used as a forked child by the benchmark/http/http_server_for_chunky_client.js).

This child file contained an error: the path still not fixed after the ff001c1 (fixed in #12904).

This child threw preventing the benchmark from completion, but this did not cause test/sequential/test-benchmark-http.js to fail:

<...>
http\end-vs-write-end.js
http\end-vs-write-end.js method="write" c=1 len=1 type="asc" benchmarker="test-double": 1
http\end-vs-write-end.js method="end" c=1 len=1 type="asc" benchmarker="test-double": 1
http\end-vs-write-end.js method="write" c=1 len=1 type="utf" benchmarker="test-double": 1
http\end-vs-write-end.js method="end" c=1 len=1 type="utf" benchmarker="test-double": 1
http\end-vs-write-end.js method="write" c=1 len=1 type="buf" benchmarker="test-double": 1
http\end-vs-write-end.js method="end" c=1 len=1 type="buf" benchmarker="test-double": 1

http\http_server_for_chunky_client.js
module.js:487
    throw err;
    ^

Error: Cannot find module '../../test/common.js'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (j:\temp\_git\node-fork\benchmark\http\_chunky_http_client.js:6:12)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)

http\simple.js
http\simple.js res="normal" c=1 chunks=0 len=1 type="bytes" benchmarker="test-double": 1
<...>

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to the benchmark subsystem.httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions