Skip to content

Can we disable the C4251 build warning on Windows? #17286

@targos

Description

@targos

It generates a huge amount of output and comes mostly from V8.

/cc @nodejs/platform-windows

Edit: documentation: https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251
Edit 2: maybe I'm imagining it but it seems that the build is faster after disabling the warning...

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.duplicateIssues and PRs that are duplicates of other issues or PRs.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions