C++ coverage broken

[addaleax]

https://coverage.nodejs.org/ displays 100 % C++ coverage for commits since 8229fc0...f878f94. I don’t see anything obvious that changed here, but f878f94 changed a sizeable part of node.gyp so that might be it?

/cc @mhdawson @yhwang

[yhwang]

that's weird. let me build the coverage locally and see if I can find anything.

[Edit]
It only verified node_main.cc for now and that's why it shows 100%

[yhwang]

@addaleax you're right. it's because of my change. only the final executable (node_main.cc) and shared lib have --coverage ldflages and cflags after my change. The condition check for coverage is mangled with other conditions. I will try to separate it from others.

[mhdawson]

@yhwang have you made any progress on this? I think we may want to back out if we can't resolve fairly soon.

[yhwang]

@mhdawson for me, the fix is quite easy. It just missed the --coverage cflags when we need a coverage build. and before my change, the --coverage is mangled with other condition check, I separated it now. The only thing left is the latest CI failures here: https://ci.nodejs.org/job/node-test-commit-linux/15961/.

And the fix actually only affects the case that --coverage is specified. When running the CI, coverage is off.