- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.5k
Closed
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.
Description
After #2367 has landed, a few things have to be fixed on the Windows and OS X installers:
Regarding the Windows installer, you can remove the following lines (linking of iojs.exe to nodejs.exe):
- https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/product.wxs#L52-L57
- https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/product.wxs#L127-L131
- https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/product.wxs#L265-L270
- https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/product.wxs#L282-L284
- https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/i18n/en-us.wxl#L15-L16
- https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/i18n/de-de.wxl#L15-L16
On OS X, these lines have to be changed:
- https://github.com/cjihrig/node-1/blob/rename/tools/osx-pkg.pmdoc/index.xml.tmpl#L31
- https://github.com/cjihrig/node-1/blob/rename/tools/osx-pkg.pmdoc/index.xml.tmpl#L39-L41
- The symlinking has to be removed on the installer script as well (couldn't find it right now).
io.js icon on the installer must be replaced as well:
https://github.com/cjihrig/node-1/blob/rename/tools/msvs/msi/product.wxs#L28
Same for the OS X installer:
https://github.com/cjihrig/node-1/blob/rename/tools/osx-pkg.pmdoc/index.xml.tmpl#L24
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.