make -s test-doc fails with Error: Cannot find module '/node-v14.4.0/tools/doc/../node_modules/eslint/node_modules/js-yaml'

[tristanls]

• Version: v14.4.0
• Platform: Linux 71c9818f32be 4.19.76-linuxkit #1 SMP Tue May 26 11:42:35 UTC 2020 x86_64 Linux
• Subsystem: ? (build?, test?)

What steps will reproduce the bug?

Dockerfile (execute using docker build --build-arg NODE_VERSION=14.4.0 .):

FROM alpine:3.12.0 AS build

ARG NODE_VERSION

RUN apk update && apk upgrade -a

RUN apk add \
    build-base \
    curl \
    gnupg \
    linux-headers \
    make \
    python3

# gpg keys from https://github.com/nodejs/node#release-keys
RUN for key in \
    4ED778F539E3634C779C87C6D7062848A1AB005C \
    B9E2F5981AA6E0CD28160D9FF13993A75599653C \
    94AE36675C464D64BAFA68DD7434390BDBE9B9C5 \
    B9AE9905FFD7803F25714661B63B535A4C206CA9 \
    77984A986EBC2AA786BC0F66B01FBB92821C587A \
    71DCFD284A79C3B38668286BC97EC7A07EDE3FC1 \
    FD3A5288F042B6850C66B31F09FE44734EB7990E \
    8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 \
    C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 \
    DD8F2338BAE7501E3DD5AC78C273792F7D83545D \
    A48C2BEE680E841632CD4E44F07496B3EB3C1762 \
    ; do \
        gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key" || \
        gpg --keyserver pgp.mit.edu --recv-keys "$key" || \
        gpg --keyserver keyserver.pgp.com --recv-keys "$key"; \
    done

RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION.tar.xz"
RUN curl -SLO --compressed "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc"
RUN gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc
RUN grep " node-v$NODE_VERSION.tar.xz\$" SHASUMS256.txt | sha256sum -c -
RUN tar -xf "node-v$NODE_VERSION.tar.xz"
WORKDIR "node-v$NODE_VERSION"
RUN uname -a
RUN ./configure --prefix /opt/node
RUN make -j$(getconf _NPROCESSORS_ONLN)
RUN make install
RUN make test

How often does it reproduce? Is there a required condition?

2 of 2 attempted builds.

What is the expected behavior?

Successful compilation and tests.

What do you see instead?

full output: output.txt

...<lots of compile output>
make -s test-doc
added 105 packages in 1.978s
internal/modules/cjs/loader.js:1032
  throw err;
  ^

Error: Cannot find module '/node-v14.4.0/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /node-v14.4.0/tools/doc/common.js
- /node-v14.4.0/tools/doc/html.js
- /node-v14.4.0/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1029:15)
    at Function.Module._load (internal/modules/cjs/loader.js:898:27)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)
    at Object.<anonymous> (/node-v14.4.0/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/node-v14.4.0/tools/doc/common.js',
    '/node-v14.4.0/tools/doc/html.js',
    '/node-v14.4.0/tools/doc/generate.js'
  ]
}
make[2]: *** [Makefile:762: out/doc/api/addons.html] Error 1
make[1]: *** [Makefile:715: doc-only] Error 2
make: *** [Makefile:320: test] Error 2
The command '/bin/sh -c make test' returned a non-zero code: 2

Additional information

[richardlau]

This is the same as #33762 — historically we have stripped out things from the source tarball for space reasons. Let’s keep the discussion over there as to whether that still makes sense.

[tristanls]

Sounds good to me @richardlau , thanks!