-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Closed
Description
Currently, Fastify tests are failing on v20 on CITGM.
The tests that are failing to shut down the process are:
- https://github.com/fastify/fastify/blob/main/test/plugin.test.js
- https://github.com/fastify/fastify/blob/main/test/schema-examples.test.js
- https://github.com/fastify/fastify/blob/main/test/schema-validation.test.js
- https://github.com/fastify/fastify/blob/main/test/serial/logger.1.test.js
- https://github.com/fastify/fastify/blob/main/test/hooks.test.js
- https://github.com/fastify/fastify/blob/main/test/hooks-async.test.js
The test passes, but it times out when it's trying to shut down the process.
This might be due to changes in the keep-alive logic in v20. It's entirely possible that those changes unveiled some bugs elsewhere, but we are having a hard time investigating this because it happens only in CI.
The other option is that it's a bug in the testing harness (tap), or coverage collection.
This might be the case because we are seeing some flaky tests in CITGM too: https://github.com/nodejs/citgm/actions/runs/6143382259/job/16666721399#step:14:618.
Metadata
Metadata
Assignees
Labels
No labels