stream_base: .writev() has limited support
#1008
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only TCP and JSStream do support `.writev()` on all platforms at the moment. Ensure that it won't be enabled everywhere. Fix: nodejs#995
|
lgtm - but I didn't test (only have my phone here) |
|
Thanks |
|
according to CI, this fixes
|
|
Yay! |
|
lgtm, can you merge @indutny or shall I? |
|
@rvagg better you |
indutny
added a commit
that referenced
this pull request
Feb 28, 2015
Only TCP and JSStream do support `.writev()` on all platforms at the moment. Ensure that it won't be enabled everywhere. Fix: #995 PR-URL: #1008 Reviewed-by: Bert Belder <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
landed @ 2b47fd2 |
This was referenced Feb 28, 2015
rvagg
added a commit
that referenced
this pull request
Mar 3, 2015
Notable changes: * stream: Fixed problems for platforms without `writev()` support, particularly Windows. Changes introduced in 1.4.1, via #926, broke some functionality for these platforms, this has now been addressed. #1008 (Fedor Indutny) * arm: We have the very beginnings of ARMv8 / ARM64 / AARCH64 support. An upgrade to OpenSSL 1.0.2 is one requirement for full support. #1028 (Ben Noordhuis) * Add new collaborator: Julian Duque @julianduque
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only TCP and JSStream do support
.writev()on all platforms at themoment. Ensure that it won't be enabled everywhere.
Fix: #995
cc @rvagg @piscisaureus should fix that writev ENOTSUP thing on windows.