Fix timers cancel in interval v4.x #10365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously not all codepaths set `timer._idleTimeout = -1` for canceled or closed timers, and not all codepaths checked it either. Unenroll uses this to say that a timer is indeed closed and it is the closest thing there is to an authoritative source for this. Refs: nodejs#9606 Fixes: nodejs#9561 PR-URL: nodejs#9685 Reviewed-By: Rich Trott <[email protected]> Conflicts: lib/timers.js
Fishrock123
added
timers
nodejs-github-bot
added
timers
3 tasks
Fishrock123
force-pushed
the
fix-timers-cancel-in-interval-v4.x
branch
from
ec26d82 to
f37b38c
Compare
|
landed in ae2eff2...c444119 |
|
LGTM |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #10365 Ref: #9685 Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #10365 Ref: #9685 Reviewed-By: Myles Borins <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
timers
Description of change
Backport of #9685 to v4.x
I added another check and testcase because there is another related bug prior to c8c2544
cc @thealphanerd
CI: https://ci.nodejs.org/job/node-test-pull-request/5498/CI: https://ci.nodejs.org/job/node-test-pull-request/5499/