Revert "src: don't overwrite non-writable vm globals" #10920
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 524f693. Fixes: nodejs#10806 Fixes: nodejs#10492 Ref: nodejs#10227
Add the regression test script presented in nodejs#10806 to `test/parallel` and re-add the original regression test for nodejs#10223 in `test/known_issues`.
nodejs-github-bot
added
c++
|
SmartOS failure in CI sure seems like unrelated build flakiness but out of a super-abundance of caution, here's a re-run on SmartOS only: https://ci.nodejs.org/job/node-test-commit-smartos/6494/ |
bnoordhuis
approved these changes
Jan 23, 2017
|
|
||
| const ctx = vm.createContext(); | ||
| vm.runInContext('Object.defineProperty(this, "x", { value: 42 })', ctx); | ||
| assert.strictEqual(ctx.x, undefined); // Not copied out by cloneProperty(). |
There was a problem hiding this comment.
For future reference: it's not IMO the expected or desired behavior, just the actual behavior.
There was a problem hiding this comment.
@bnoordhuis Right, I agree. Would you prefer it if I updated the test with strictEqual(ctx.x, 42) here?
There was a problem hiding this comment.
No need, it was more of an off-the-cuff remark.
fhinkel
approved these changes
Jan 23, 2017
| return; | ||
| ctx->global_proxy()->HasRealNamedProperty(ctx->context(), | ||
| property).FromJust(); | ||
| bool is_contextual_store = ctx->global_proxy() != args.This(); |
There was a problem hiding this comment.
We came to the conclusion that is_contextual_store is always true and shouldn't be here in the first place. Do you want to remove it from the revert or should I make an extra PR. Extra PR probably keeps history and bisects cleaner.
There was a problem hiding this comment.
Yeah, an extra PR sounds better – mostly because
a) this PR can be landed now (if anybody reading this has a few minutes left over, please feel free to take that task) and
b) because my understanding of this code is actually kind of limited ;)
addaleax
added a commit
that referenced
this pull request
Jan 25, 2017
This reverts commit 524f693. Fixes: #10806 Fixes: #10492 Ref: #10227 PR-URL: #10920 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
addaleax
added a commit
that referenced
this pull request
Jan 25, 2017
Add the regression test script presented in #10806 to `test/parallel` and re-add the original regression test for #10223 in `test/known_issues`. PR-URL: #10920 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
This reverts commit 524f693. Fixes: #10806 Fixes: #10492 Ref: #10227 PR-URL: #10920 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
Add the regression test script presented in #10806 to `test/parallel` and re-add the original regression test for #10223 in `test/known_issues`. PR-URL: #10920 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
This reverts commit 524f693. Fixes: nodejs#10806 Fixes: nodejs#10492 Ref: nodejs#10227 PR-URL: nodejs#10920 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Add the regression test script presented in nodejs#10806 to `test/parallel` and re-add the original regression test for nodejs#10223 in `test/known_issues`. PR-URL: nodejs#10920 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
This reverts commit 524f693. Fixes: nodejs#10806 Fixes: nodejs#10492 Ref: nodejs#10227 PR-URL: nodejs#10920 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Add the regression test script presented in nodejs#10806 to `test/parallel` and re-add the original regression test for nodejs#10223 in `test/known_issues`. PR-URL: nodejs#10920 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @bnoordhuis @fhinkel
CI: https://ci.nodejs.org/job/node-test-commit/7383/