Skip to content

doc: add not-an-aardvark as ESLint contact #11169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: add not-an-aardvark as ESLint contact #11169

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 4, 2017

Add not-an-aardvark as someone to CC for ESLint issues.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc tools

@Trott
doc: add not-an-aardvark as ESLint contact
52350d7 
Add not-an-aardvark as someone to CC for ESLint issues.
@Trott Trott added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Feb 4, 2017
@Trott Trott requested a review from not-an-aardvark February 4, 2017 20:06
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 4, 2017
jasnell
jasnell approved these changes Feb 6, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to wait the 48 hours to land

jasnell pushed a commit that referenced this pull request Feb 6, 2017
@Trott @jasnell
doc: add not-an-aardvark as ESLint contact
6c7fbd7 
Add not-an-aardvark as someone to CC for ESLint issues.

PR-URL: #11169
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 6, 2017

Landed in 6c7fbd7

@jasnell jasnell closed this Feb 6, 2017
italoacasas pushed a commit that referenced this pull request Feb 6, 2017
@Trott
doc: add not-an-aardvark as ESLint contact
d20afc2 
Add not-an-aardvark as someone to CC for ESLint issues.

PR-URL: #11169
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
@Trott
doc: add not-an-aardvark as ESLint contact
1fbbcc3 
Add not-an-aardvark as someone to CC for ESLint issues.

PR-URL: nodejs#11169
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@Trott @krydos
doc: add not-an-aardvark as ESLint contact
91bc2a2 
Add not-an-aardvark as someone to CC for ESLint issues.

PR-URL: nodejs#11169
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott @jasnell
doc: add not-an-aardvark as ESLint contact
a3e7461 
Add not-an-aardvark as someone to CC for ESLint issues.

PR-URL: #11169
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@Trott @jasnell
doc: add not-an-aardvark as ESLint contact
6af30ec 
Add not-an-aardvark as someone to CC for ESLint issues.

PR-URL: #11169
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
doc: add not-an-aardvark as ESLint contact
207142d 
Add not-an-aardvark as someone to CC for ESLint issues.

PR-URL: #11169
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@Trott @MylesBorins
doc: add not-an-aardvark as ESLint contact
2016aa4 
Add not-an-aardvark as someone to CC for ESLint issues.

PR-URL: #11169
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
@Trott Trott deleted the teddy-eslint branch October 10, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+3 more reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott @jasnell @thefourtheye @lpinca @cjihrig @not-an-aardvark @gibfahn @nodejs-github-bot