Skip to content

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Mar 22, 2017

Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Mar 22, 2017
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buffers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimothyGu you mean the buffers that was already there should be uppercase? makes sense, updated

@addaleax addaleax force-pushed the crypto-uint8array-doc branch from 1d68984 to bf026b0 Compare March 24, 2017 02:50
@addaleax addaleax force-pushed the crypto-uint8array-doc branch from bf026b0 to ad775e1 Compare March 24, 2017 02:50
jasnell pushed a commit that referenced this pull request Mar 24, 2017
PR-URL: #11982
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 24, 2017

Landed in e40ac30

@MylesBorins
Copy link
Contributor

This will require a manual backport to v7.x

@addaleax addaleax deleted the crypto-uint8array-doc branch March 28, 2017 22:39
@jasnell jasnell mentioned this pull request Apr 4, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants