Docsupport4x #12091
Docsupport4x #12091
Conversation
nodejs-github-bot
added
build
|
@joaocgreis can you validate this is correct for Windows |
BUILDING.md
Outdated
There was a problem hiding this comment.
I believe this was better as it was, VS2015 is supported for building v4.x.
|
@joaocgreis pushed commit to address comment. |
|
@misterdjules @geek, does the smartOs part look right to you for 4.X ? |
BUILDING.md
Outdated
There was a problem hiding this comment.
Why is it an = and not >=? In other words, do you mean that you think node v4.x doesn't run on SmartOS 15.x or 16.x images?
There was a problem hiding this comment.
I probably changed that because of the way the build machines were setup. If it does run on 15, and 16 is should be >=, will update.
|
@mhdawson Thanks for the heads up! I left a question as a comment. |
MylesBorins
force-pushed
the
v4.x-staging
branch
from
0a1ff59 to
c63e02a
Compare
Original Commit Message: PR-URL: nodejs#11872 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Backport-Of: nodejs#11872 PR-URL: nodejs#11943 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Original Commit Message: PR-URL: nodejs#11943 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-Of: nodejs#11943
|
@misterdjules pushed commit to address your comment and rebased. |
|
@mhdawson The SmartOS part looks good to me. Thanks again! |
BUILDING.md
Outdated
| #### Unix | ||
|
|
||
| * GCC 4.8 or newer | ||
| * Clang 3.4 or newer |
| ``` | ||
|
|
||
| Note that the above requires that `python` resolve to Python 2.6 or 2.7 | ||
| and not a newer version. |
There was a problem hiding this comment.
Seems more clear to me to just point out that python 3.x isn't supported.
|
Since the versions we landed in master, and 6 describe the python dependency as it is shown lets leave it the same for consistency. Will update to say clang 3.4.1 6.x will need to be update for that as well. |
|
@jbergstroem pushed requested change |
PR-URL: #12091 Reviewed-By: James M Snell <[email protected]> Reviewed-By: JoãReis <[email protected]> Reviewed-By: Johan Bergströ[email protected]>
|
landed in v4.x-staging as 918a26f |
PR-URL: #12091 Reviewed-By: James M Snell <[email protected]> Reviewed-By: JoãReis <[email protected]> Reviewed-By: Johan Bergströ[email protected]>
PR-URL: #12091 Reviewed-By: James M Snell <[email protected]> Reviewed-By: JoãReis <[email protected]> Reviewed-By: Johan Bergströ[email protected]>
6 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc
First 2 commits are backports of the original changes to master and the updates for v6.x.
The last commit updates for the changes needed for 4.x