Skip to content

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Apr 5, 2017

Currently the building of addons and addons-napi are done sequentially
but could be done in parallel which this commit tries to address.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Currently the building of addons and addons-napi are done sequentially
but could be done in parallel which this commit tries to address.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 5, 2017
@danbev
Copy link
Contributor Author

danbev commented Apr 5, 2017

@danbev danbev mentioned this pull request Apr 5, 2017
2 tasks
@thefourtheye
Copy link
Contributor

I am not in favour. Mainly because the compilation logs are interleaved and difficult to understand. That said, I am 0 on this.

@bnoordhuis
Copy link
Member

I have a somewhat more rigorous approach in #12231 that also addresses the issue that caused #11628.

@danbev
Copy link
Contributor Author

danbev commented Apr 5, 2017

Closing in favour of #12231

@danbev danbev closed this Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants