Skip to content

Revert "openssl: don't define SIXTY_FOUR_BIT_LONG on Windows" #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "openssl: don't define SIXTY_FOUR_BIT_LONG on Windows" #125

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

This reverts commit 878cc3e.

Reverted for breaking the x86_64 Linux build:

In file included from ../deps/openssl/openssl/include/openssl/bn.h:1:0,
                 from ../deps/openssl/openssl/crypto/bn/asm/../bn_lcl.h:115,
                 from ../deps/openssl/openssl/crypto/bn/asm/x86_64-gcc.c:1:
../deps/openssl/openssl/include/openssl/../../crypto/bn/bn.h:813:20: note: previous declaration of 'bn_add_words' was here
 BN_ULONG bn_add_words(BN_ULONG *rp, const BN_ULONG *ap, const BN_ULONG *bp,int num);
                    ^
../deps/openssl/openssl/crypto/bn/asm/x86_64-gcc.c:210:15: error: conflicting types for 'bn_sub_words'
 BN_ULONG bn_sub_words (BN_ULONG *rp, const BN_ULONG *ap, const BN_ULONG *bp,int n)

R=@piscisaureus

@bnoordhuis
Revert "openssl: don't define SIXTY_FOUR_BIT_LONG on Windows"
a4c5489 
This reverts commit 878cc3e.

Reverted for breaking the x86_64 Linux build:

    In file included from ../deps/openssl/openssl/include/openssl/bn.h:1:0,
                     from ../deps/openssl/openssl/crypto/bn/asm/../bn_lcl.h:115,
                     from ../deps/openssl/openssl/crypto/bn/asm/x86_64-gcc.c:1:
    ../deps/openssl/openssl/include/openssl/../../crypto/bn/bn.h:813:20: note: previous declaration of 'bn_add_words' was here
     BN_ULONG bn_add_words(BN_ULONG *rp, const BN_ULONG *ap, const BN_ULONG *bp,int num);
                        ^
    ../deps/openssl/openssl/crypto/bn/asm/x86_64-gcc.c:210:15: error: conflicting types for 'bn_sub_words'
     BN_ULONG bn_sub_words (BN_ULONG *rp, const BN_ULONG *ap, const BN_ULONG *bp,int n)
@bnoordhuis bnoordhuis mentioned this pull request Dec 9, 2014
Merged
@piscisaureus piscisaureus added the wip Issues and PRs that are still a work in progress. label Dec 9, 2014
@piscisaureus
Copy link
Contributor

4ccc5a6

@piscisaureus piscisaureus removed the wip Issues and PRs that are still a work in progress. label Dec 9, 2014
@wmertens wmertens mentioned this pull request Jun 19, 2020
Closed
This was referenced May 26, 2021
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jun 17, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 30, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 4, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 21, 2021
Open
@zzo38 zzo38 mentioned this pull request Jul 3, 2022
Closed
@pratapadi pratapadi mentioned this pull request Aug 11, 2022
Open
@aborovsky aborovsky mentioned this pull request Aug 24, 2023
Closed
@AyushG3112 AyushG3112 mentioned this pull request Nov 30, 2023
Open
@thakursachin467 thakursachin467 mentioned this pull request Nov 30, 2023
Open
@RoeeOren RoeeOren mentioned this pull request Nov 30, 2023
Open
@GregorFendt GregorFendt mentioned this pull request Nov 30, 2023
Open
@timzwit timzwit mentioned this pull request Nov 30, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 30, 2023
Open
@nickfnblum nickfnblum mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
@137717unity 137717unity mentioned this pull request Nov 30, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Open
@bumplzz69 bumplzz69 mentioned this pull request Nov 30, 2023
Open
@baby636 baby636 mentioned this pull request Nov 30, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Nov 30, 2023
Open
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request Nov 30, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Nov 30, 2023
Open
@BryanLaura BryanLaura mentioned this pull request Nov 30, 2023
Open
@pratapadi pratapadi mentioned this pull request Nov 30, 2023
Open
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request Nov 30, 2023
Open
@BryanLaura BryanLaura mentioned this pull request Nov 30, 2023
Open
@dannybrown13 dannybrown13 mentioned this pull request Nov 30, 2023
Open
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request Nov 30, 2023
Open
@BryanLaura BryanLaura mentioned this pull request Nov 30, 2023
Open
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request Nov 30, 2023
Open
@xphillyx xphillyx mentioned this pull request Nov 30, 2023
Open
@sirinartk sirinartk mentioned this pull request Dec 1, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Dec 1, 2023
Open
@pratapadi pratapadi mentioned this pull request Dec 1, 2023
Open
@dannybrown13 dannybrown13 mentioned this pull request Dec 1, 2023
Open
@BryanLaura BryanLaura mentioned this pull request Dec 1, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Dec 1, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Dec 1, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 1, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 1, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Dec 1, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Dec 1, 2023
Open
@timzwit timzwit mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bnoordhuis bnoordhuis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bnoordhuis @piscisaureus