Skip to content

Conversation

rayto510
Copy link

@rayto510 rayto510 commented May 2, 2017

…odified

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 2, 2017
@vsemozhetbyt
Copy link
Contributor

@refack
Copy link
Contributor

refack commented May 2, 2017

@rayto510 Thank you for the contribution! 🥇
Two comments:

  1. The commit message should follow our guidelines
  2. Both the commit message and PR description should state what is the motivation for the suggesting this change

@rayto510 rayto510 closed this May 2, 2017
@refack
Copy link
Contributor

refack commented May 2, 2017

Superseded by #12798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants