stream: improve readable push performance #13113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
performance
|
When CITGM is restored, a CITGM run would be highly welcomed. |
mscdex
force-pushed
the
stream-readable-push-perf
branch
from
22eade4 to
89aa63b
Compare
jasnell
approved these changes
May 22, 2017
|
There does not seem to be any CITGM failures caused by this particular PR. |
|
@mscdex great news, LGTM! |
mscdex
force-pushed
the
stream-readable-push-perf
branch
from
89aa63b to
b94a7e0
Compare
|
Landed in 359ea2a |
addaleax
pushed a commit
that referenced
this pull request
May 23, 2017
PR-URL: #13113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 24, 2017
PR-URL: #13113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
PR-URL: #13113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
3 tasks
MylesBorins
added
baking-for-lts
|
Should this be backported? Letting it bake for a little bit if so |
|
I'm 👍 on waiting, but it can be backported. |
MylesBorins
removed
the
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly about improving performance when pushing strings, but pushing Buffers seems to be just a tad faster too. Specifically this PR makes two types of changes: avoid unnecessary chunk validation and reducing duplicated conditionals.
Here are results from one of the benchmark files I modified to be able to test strings:
CI: https://ci.nodejs.org/job/node-test-pull-request/8170/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)