Skip to content

Conversation

kaspars
Copy link

@kaspars kaspars commented Apr 1, 2015

No description provided.

@bnoordhuis
Copy link
Member

Can you send this to upstream V8? We don't accept out-of-tree patches for our dependencies. I'll be happy to cherry-pick it once it lands.

/cc @qbit - maybe you can assist @kaspars?

@bnoordhuis bnoordhuis closed this Apr 1, 2015
@kaspars
Copy link
Author

kaspars commented Apr 1, 2015

thanks @bnoordhuis for suggestion.
but, well, I just checked out the v8 repository, and realized that the required change is already there. See the commit 71fd742f in v8.
https://chromium.googlesource.com/v8/v8.git/+/71fd742fc6f297991bd9fdd1bebc95a75139775c%5E%21/#F0

@qbit
Copy link
Contributor

qbit commented Apr 1, 2015

👍 @kaspars if you are interested, I have a port for 1.6.3!

@kaspars
Copy link
Author

kaspars commented Apr 1, 2015

thanks, will check it out!

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 1, 2015
Cherry-pick https://codereview.chromium.org/856553002 from upstream.

Makes V8 on OpenBSD/amd64 pick up the right V8_INT64_C and V8_UINT64_C
macros.

PR-URL: nodejs#1318
Refs: nodejs#1312
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants