Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/_stream_writable.js
Original file line number Diff line number Diff line change
Expand Up @@ -358,14 +358,19 @@ function doWrite(stream, state, writev, len, chunk, encoding, cb) {
function onwriteError(stream, state, sync, er, cb) {
--state.pendingcb;
if (sync)
process.nextTick(cb, er);
process.nextTick(afterError, stream, state, cb, er);
else
cb(er);
afterError(stream, state, cb, er);

stream._writableState.errorEmitted = true;
stream.emit('error', er);
}

function afterError(stream, state, cb, err) {
cb(err);
finishMaybe(stream, state);
}

function onwriteStateUpdate(state) {
state.writing = false;
state.writecb = null;
Expand Down
53 changes: 53 additions & 0 deletions test/parallel/test-stream-writable-writev-finish.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const stream = require('stream');

// ensure consistency between the finish event when using cork()
// and writev and when not using them

{
const writable = new stream.Writable();

writable._write = (chunks, encoding, cb) => {
cb(new Error('write test error'));
};

writable.on('finish', common.mustCall());

writable.on('prefinish', common.mustCall());

writable.on('error', common.mustCall((er) => {
assert.strictEqual(er.message, 'write test error');
}));

writable.end('test');
}

{
const writable = new stream.Writable();

writable._write = (chunks, encoding, cb) => {
cb(new Error('write test error'));
};

writable._writev = (chunks, cb) => {
cb(new Error('writev test error'));
};

writable.on('finish', common.mustCall());

writable.on('prefinish', common.mustCall());

writable.on('error', common.mustCall((er) => {
assert.strictEqual(er.message, 'writev test error');
}));

writable.cork();
writable.write('test');

setImmediate(function() {
writable.end('test');
});
}