doc: corrects reference to tlsClientError #13533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
refack
approved these changes
Jun 7, 2017
silverwind
approved these changes
Jun 8, 2017
|
Thanks! Landed in 597ba15. |
silverwind
pushed a commit
that referenced
this pull request
Jun 8, 2017
After the renaming of `clientError` in TLS to `tlsClientError` in 1ab6b21, the docs inconsistently referred the error as `clientError`, which is now corrected. Fixes: #13417 PR-URL: #13533 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2017
After the renaming of `clientError` in TLS to `tlsClientError` in 1ab6b21, the docs inconsistently referred the error as `clientError`, which is now corrected. Fixes: #13417 PR-URL: #13533 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
After the renaming of `clientError` in TLS to `tlsClientError` in 1ab6b21, the docs inconsistently referred the error as `clientError`, which is now corrected. Fixes: #13417 PR-URL: #13533 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the renaming of
clientErrorin TLS totlsClientErrorin 1ab6b21,the docs inconsistently referred the error as
clientError, which is nowcorrected.
It can be confirmed by looking at this line, the error generated on timeout is
tlsClientErrorand notclientError, making the current doc wrong.Fixes: #13417
PR-URL: #13533
Checklist
Affected core subsystem(s)
doc