test: improve http test reliability #13693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
http
mscdex
force-pushed
the
test-http-improve-client-immediate-error
branch
from
92f7dc6 to
6948503
Compare
mscdex
force-pushed
the
test-http-improve-client-immediate-error
branch
2 times, most recently
from
24c7713 to
0556dff
Compare
jasnell
approved these changes
Jun 15, 2017
Fake the socket handle to ensure an immediate error is returned uniformly across all platforms. PR-URL: nodejs#13693 Reviewed-By: James M Snell <[email protected]>
mscdex
force-pushed
the
test-http-improve-client-immediate-error
branch
from
0556dff to
fcd82e7
Compare
addaleax
pushed a commit
that referenced
this pull request
Jun 18, 2017
Fake the socket handle to ensure an immediate error is returned uniformly across all platforms. PR-URL: #13693 Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 20, 2017
Fake the socket handle to ensure an immediate error is returned uniformly across all platforms. PR-URL: #13693 Reviewed-By: James M Snell <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
Fake the socket handle to ensure an immediate error is returned uniformly across all platforms. PR-URL: #13693 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fake the socket handle to ensure an immediate error is returned uniformly across all platforms.
CI: https://ci.nodejs.org/job/node-test-pull-request/8670/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)