Skip to content

util: fix inspect array w. negative maxArrayLength #14880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

util: fix inspect array w. negative maxArrayLength #14880

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This fixes a regression introduced in 95bbb68.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

util

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Aug 17, 2017
@BridgeAR BridgeAR mentioned this pull request Aug 17, 2017
Closed
4 tasks
@aqrln
Copy link
Contributor

aqrln commented Aug 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9710/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 21, 2017
@BridgeAR
util: fix inspect array w. negative maxArrayLength
3a886ff 
PR-URL: nodejs#14880
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BridgeAR
Copy link
Member Author

Landed in 3a886ff

@BridgeAR BridgeAR closed this Aug 21, 2017
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@BridgeAR @MylesBorins
util: fix inspect array w. negative maxArrayLength
25833a5 
PR-URL: #14880
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@BridgeAR @MylesBorins
util: fix inspect array w. negative maxArrayLength
de10c0f 
PR-URL: #14880
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 20, 2017
Closed
4 tasks
@MylesBorins MylesBorins added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Sep 20, 2017
@MylesBorins
Copy link
Contributor

Needs to land with 95bbb68

@MylesBorins MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

+2 more reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@aqrln aqrln aqrln approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@BridgeAR @aqrln @MylesBorins @jasnell @addaleax @TimothyGu @cjihrig @tniessen @nodejs-github-bot