test: backward compatible api for tty #15235
Conversation
There was a problem hiding this comment.
Nit: this should be the first module to be required.
There was a problem hiding this comment.
Nit: space after { and before }. ReadStream doesn't seem to be used in the test.
|
@lpinca should be all fixed :) |
|
@gergelyke seems like the test is constantly failing. Please take another look. |
|
@BridgeAR can you help me what's the exact cause of the failure? cannot really find it in the logs :/ |
|
this is the error message I get locally: seems unrelated to my changes |
|
@gergelyke this is the error Try to run the tests again. They should work properly. |
|
Ahh, had to run |
|
still the same issue :/ @trevnorris any chance you have a clue what could go wrong? |
|
@gergelyke try to manually delete the test folders. See #13582. |
|
That helped, thanks. However, I don't really understand the problem here. Based on the libuv docs (http://docs.libuv.org/en/v1.x/tty.html#c.uv_tty_init), the integer should be either 0, 1 or 2. Any idea why it fails? |
There was a problem hiding this comment.
I'd remove this as it seems to be no longer used.
|
@lpinca would you be so kind and re-approve? |
|
Still LGTM but it would be nice if there were more approval. |
PR-URL: nodejs#15235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
|
Landed in 750c080 |
PR-URL: #15235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
PR-URL: nodejs/node#15235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
PR-URL: nodejs/node#15235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
PR-URL: #15235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
PR-URL: #15235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
8 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tty