src: remove unused perf_hooks uv handles #15368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of unused uv handles were accidentally left in env.
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Sep 12, 2017
|
LGTM if CI is ok: https://ci.nodejs.org/job/node-test-pull-request/10046/ |
addaleax
approved these changes
Sep 13, 2017
|
CI looks good, I don’t think this needs to wait 48 hours |
jasnell
added a commit
that referenced
this pull request
Sep 13, 2017
A couple of unused uv handles were accidentally left in env. PR-URL: #15368 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Brian White <[email protected]>
|
Landed in dcc41fd |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
A couple of unused uv handles were accidentally left in env. PR-URL: nodejs/node#15368 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Brian White <[email protected]>
jasnell
added a commit
that referenced
this pull request
Sep 20, 2017
A couple of unused uv handles were accidentally left in env. PR-URL: #15368 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Brian White <[email protected]>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
A couple of unused uv handles were accidentally left in env. PR-URL: nodejs/node#15368 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Brian White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of unused uv handles were accidentally left in env.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src