cli: adds support for --pending-deprecation in NODE_OPTIONS. #15494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
mscdex
added
the
cli
jasnell
approved these changes
Sep 20, 2017
cjihrig
approved these changes
Sep 21, 2017
BridgeAR
approved these changes
Sep 24, 2017
|
Landed in 3d7f7b2 |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 24, 2017
PR-URL: #15494 Fixes: #15484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
@tomc974 congratulations to your first commit to Node.js! 🎉 |
jasnell
pushed a commit
that referenced
this pull request
Sep 25, 2017
PR-URL: #15494 Fixes: #15484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
PR-URL: nodejs/node#15494 Fixes: nodejs/node#15484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Should this be backported to 6.x? We now have support for NODE_OPTIONS and the PR lands cleanly As an aside, should this have been landed as Semver-Minor? |
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #15494 Fixes: #15484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
I'm going to land this and stick to original semveryness |
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15494 Fixes: #15484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15494 Fixes: #15484 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15484
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
cli