Skip to content

Conversation

@vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, meta

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 29, 2017
@vsemozhetbyt
Copy link
Contributor Author

I do not know how to fix this link in the doc/releases.md#3-a-publicly-listed-gpg-key:

https://sks-keyservers.net/i/#submit (404 Not Found)

Let me know about the equivalent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to use CONTRIBUTING.md#commit-message-guidelines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lpinca
Copy link
Member

lpinca commented Sep 29, 2017

@vsemozhetbyt maybe http://hkps.pool.sks-keyservers.net/?

@vsemozhetbyt
Copy link
Contributor Author

Thank you, Let's see what others think.

The https://sks-keyservers.net/ itself is OK, it just https://sks-keyservers.net/i/#submit (some form?) is now 404.

@TimothyGu
Copy link
Member

How http://hkps.pool.sks-keyservers.net looks is different for everybody because it's just a mirror to a pool of key servers. For me personally, just two minutes ago that URL showed "keyserver.ntzwrk.org" but now it shows "keys2.kfwebs.net". Because of that, the submission feature may not always be available on the mirror the URL currently redirects to; the anchor for the "Submit" section may certainly be different as well.

I would just pick one keyserver, like the one provided by MIT or by Ubuntu/Canonical. They end up getting synced pretty soon anyway.

@vsemozhetbyt
Copy link
Contributor Author

Rebased after 9807744

@vsemozhetbyt
Copy link
Contributor Author

@TimothyGu Can you suggest a wording with one of your links (or both)?

jasnell pushed a commit that referenced this pull request Oct 1, 2017
PR-URL: #15675
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 1, 2017

Went ahead and landed in 6be96c7. We can make further changes in a separate PR

@BridgeAR BridgeAR closed this Oct 1, 2017
@vsemozhetbyt vsemozhetbyt deleted the doc-gh-links branch October 1, 2017 07:17
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
PR-URL: #15675
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
PR-URL: #15675
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
PR-URL: nodejs/node#15675
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #15675
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
PR-URL: #15675
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #15675
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants