test: update fixturesDir import #15887
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
code-and-learn
|
Hi, @seabrookmx! Welcome and thanks for this! Can you update this to use |
BridgeAR
reviewed
Oct 9, 2017
test/sequential/test-stream2-fs.js
Outdated
There was a problem hiding this comment.
There is a dedicated fixtures.path function that could be used here.
|
Ah, sorry @Trott I did not read your comment before writing mine. |
jasnell
approved these changes
Oct 10, 2017
Import fixturesDir path from common/fixturesDir module rather than from common.
|
@Trott Thanks for the link. Commit updated 🙇♂️ |
|
@seabrookmx - thanks, can you also apply @BridgeAR's recommendation to improve the code further? |
lpinca
reviewed
Oct 13, 2017
test/sequential/test-stream2-fs.js
Outdated
|
|
||
| const path = require('path'); | ||
| const file = path.resolve(common.fixturesDir, 'x1024.txt'); | ||
| const file = path.resolve(fixtures.path(), 'x1024.txt'); |
There was a problem hiding this comment.
This could be just fixtures.path('x1024.txt').
joyeecheung
approved these changes
Oct 14, 2017
|
Landed in bb56fbb, thank you for the contribution! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 14, 2017
Import fixturesDir path from common/fixturesDir module rather than from common. PR-URL: #15887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Import fixturesDir path from common/fixturesDir module rather than from common. PR-URL: nodejs/node#15887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Import fixturesDir path from common/fixturesDir module rather than from common. PR-URL: #15887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Import fixturesDir path from common/fixturesDir module rather than from common. PR-URL: #15887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Import fixturesDir path from common/fixturesDir module rather than from common. PR-URL: #15887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Import fixturesDir path from common/fixturesDir module rather than from common. PR-URL: #15887 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import fixturesDir path from common/fixturesDir
module rather than from common.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)