doc: add recommendations for first timers #16350
Conversation
COLLABORATOR_GUIDE.md
Outdated
There was a problem hiding this comment.
recommanded -> recommended ?
There was a problem hiding this comment.
You could also drop the first four words:
Be extra welcoming to "first-time-contributors".
I'd use especially in place of extra and lose the unnecessary quotes and hyphens:
Be especially welcoming to first time contributors.
COLLABORATOR_GUIDE.md
Outdated
There was a problem hiding this comment.
- recommanded -> recommended ?
- Avoid "you"?
There was a problem hiding this comment.
Maybe remove the "it is recommended that you"?:
For first time contributors, ask the author if they have configured...
COLLABORATOR_GUIDE.md
Outdated
There was a problem hiding this comment.
Not an objection, but just a comment that I try to be very sparing with bold, italics, etc. It gets out of hand pretty easily.
COLLABORATOR_GUIDE.md
Outdated
COLLABORATOR_GUIDE.md
Outdated
There was a problem hiding this comment.
minor nit: blank line before this sentence?
refack
force-pushed
the
collab-guide-tweaks
branch
from
bb62506 to
f5c8192
Compare
COLLABORATOR_GUIDE.md
Outdated
There was a problem hiding this comment.
Not an objection, but just a comment that I try to be very sparing with bold, italics, etc. It gets out of hand pretty easily.
Ack. I felt this is a point worth emphasising both to Collaborators, and to contributors who read this (as on most screens it appears above the fold)
|
Addressed comment PTAL |
refack
force-pushed
the
collab-guide-tweaks
branch
from
f5c8192 to
a9de89a
Compare
PR-URL: nodejs#16350 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #16350 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: nodejs/node#16350 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #16350 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #16350 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #16350 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: nodejs/node#16350 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
10 participants
Checklist
Affected core subsystem(s)
doc,meta