Skip to content

test: add assertions for TextEncoder/Decoder #18132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: add assertions for TextEncoder/Decoder #18132

wants to merge 1 commit into from
+51 −24

Conversation

shqld
Copy link

@shqld shqld commented Jan 13, 2018

Added some assertions for TextEncoder/Decoder to expand branch coverage(https://coverage.nodejs.org/coverage-1385e1bc63665b8c/root/internal/encoding.js.html).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 13, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/15506/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
@addaleax
Copy link
Member

Landed in 7972bdf

@addaleax addaleax closed this Jan 18, 2018
addaleax pushed a commit that referenced this pull request Jan 18, 2018
@addaleax
test: add assertions for TextEncoder/Decoder
7972bdf 
PR-URL: #18132
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@evanlucas
test: add assertions for TextEncoder/Decoder
2b13fda 
PR-URL: #18132
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@evanlucas
test: add assertions for TextEncoder/Decoder
5b5f5b1 
PR-URL: #18132
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@lance lance mentioned this pull request Mar 14, 2018
Closed
3 tasks
@lance
Copy link
Member

lance commented Mar 14, 2018 •
edited
Loading

@MylesBorins this cannot be backported to v6.x-staging since it depends on #13644 which is labled dont-land-on-v6. I've removed the backport-requested-v6.x label and submitted a backport PR for v8.x-staging.

MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@MylesBorins
test: add assertions for TextEncoder/Decoder
a618966 
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@MylesBorins
test: add assertions for TextEncoder/Decoder
88e0f23 
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@MylesBorins
test: add assertions for TextEncoder/Decoder
e42ab10 
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MayaLekova
test: add assertions for TextEncoder/Decoder
1ce221b 
PR-URL: nodejs#18132
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@TimothyGu TimothyGu TimothyGu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@shqld @addaleax @MylesBorins @lance @jasnell @lpinca @TimothyGu @cjihrig @nodejs-github-bot