Skip to content

Conversation

BridgeAR
Copy link
Member

Potential alternative to #20228

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 23, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 23, 2018

@BridgeAR
Copy link
Member Author

This currently has a false positive for fedora. Does anyone know what could be added to distinguish fedora and alpine?

@devsnek
Copy link
Member

devsnek commented Apr 23, 2018

lsb_release or check for /etc/alpine-release maybe? I don't know much about alpine

@BridgeAR
Copy link
Member Author

Closing for now. The original PR got reverted.

@BridgeAR BridgeAR closed this Apr 24, 2018
@BridgeAR BridgeAR deleted the add-alpine-check branch January 20, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants