n-api: remove unused Test function #20320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when building the following warning is emitted:
../test_symbol.c:4:19:
warning: unused function 'Test' [-Wunused-function]
static napi_value Test(napi_env env, napi_callback_info info) {
^
1 warning generated.
This commit removes this unused function.
nodejs-github-bot
added
dont-land-on-v4.x
node-api
joyeecheung
added
the
fast-track
joyeecheung
approved these changes
Apr 26, 2018
trivikr
approved these changes
Apr 26, 2018
BridgeAR
approved these changes
Apr 26, 2018
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 26, 2018
Currently when building the following warning is emitted:
../test_symbol.c:4:19:
warning: unused function 'Test' [-Wunused-function]
static napi_value Test(napi_env env, napi_callback_info info) {
^
1 warning generated.
This commit removes this unused function.
PR-URL: nodejs#20320
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 6606a26 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Currently when building the following warning is emitted:
../test_symbol.c:4:19:
warning: unused function 'Test' [-Wunused-function]
static napi_value Test(napi_env env, napi_callback_info info) {
^
1 warning generated.
This commit removes this unused function.
PR-URL: #20320
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when building the following warning is emitted:
This commit removes this unused function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes