n-api: document that native strings are copied #20425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention that a copy is made of the native string by the napi_create_string_* APIs. Fixes: nodejs/abi-stable-node#304
nodejs-github-bot
added
doc
vsemozhetbyt
approved these changes
Apr 30, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
fast-track
TimothyGu
approved these changes
Apr 30, 2018
gabrielschulhof
pushed a commit
that referenced
this pull request
Apr 30, 2018
Mention that a copy is made of the native string by the napi_create_string_* APIs. Fixes: nodejs/abi-stable-node#304 PR-URL: #20425 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
|
Landed in 8062431. |
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Mention that a copy is made of the native string by the napi_create_string_* APIs. Fixes: nodejs/abi-stable-node#304 PR-URL: #20425 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention that a copy is made of the native string by the
napi_create_string_* APIs.
Fixes: nodejs/abi-stable-node#304
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes