Skip to content

Conversation

kakts
Copy link
Contributor

@kakts kakts commented May 17, 2018

Summary

Fix fs.promises sample codes in doc/api/fs.md .

Please review this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 17, 2018
@benjamingr
Copy link
Member

Thanks, I'm +1 on the change though note that #20559 is landing soon

# Conflicts:
#	doc/api/fs.md
@kakts
Copy link
Contributor Author

kakts commented May 19, 2018

I'll close this PR and recreate.

@kakts kakts closed this May 19, 2018
@kakts kakts mentioned this pull request May 19, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants