test: add promise API test for appendFile() #20842
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the second of five test cases in test-fs-append-fil to the promise-based API in addition to the callback-based API.
cjihrig
approved these changes
May 20, 2018
BridgeAR
approved these changes
May 20, 2018
BridgeAR
added
the
author ready
trivikr
approved these changes
May 20, 2018
benjamingr
approved these changes
May 20, 2018
|
Re-running failed Windows CI although Windows CI seems to be a bit of a problem right now so I'm not sure this is going to go green: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18141/ |
|
Windows CI re-run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18160/ |
|
Landed in a3d174c |
apapirovski
pushed a commit
that referenced
this pull request
May 22, 2018
Apply the second of five test cases in test-fs-append-fil to the promise-based API in addition to the callback-based API. PR-URL: #20842 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Apply the second of five test cases in test-fs-append-fil to the promise-based API in addition to the callback-based API. PR-URL: #20842 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
Apply the second of five test cases in test-fs-append-fil to the promise-based API in addition to the callback-based API. PR-URL: #20842 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the second of five test cases in test-fs-append-fil to the
promise-based API in addition to the callback-based API.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes