Skip to content

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Jun 12, 2018

8.x: #21294

Original commit message:

[runtime] Fix derived class instantiation

Bug: chromium:806388
Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c
Reviewed-on: https://chromium-review.googlesource.com/894942
Reviewed-by: Igor Sheludko [email protected]
Commit-Queue: Camillo Bruni [email protected]
Cr-Commit-Position: refs/heads/master@{#50990}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

/cc @nodejs/v8-update

CI: https://ci.nodejs.org/job/node-test-pull-request/15466/
V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1424/

@nodejs-github-bot
Copy link
Collaborator

@ofrobots sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. v9.x labels Jun 12, 2018
Original commit message:
  [runtime] Fix derived class instantiation

  Bug: chromium:806388
  Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c
  Reviewed-on: https://chromium-review.googlesource.com/894942
  Reviewed-by: Igor Sheludko <[email protected]>
  Commit-Queue: Camillo Bruni <[email protected]>
  Cr-Commit-Position: refs/heads/master@{nodejs#50990}
@ofrobots ofrobots force-pushed the backport/9/806388 branch from 6c427fa to 7d85eb0 Compare June 14, 2018 18:52
@ofrobots
Copy link
Contributor Author

Abandoning, as no more releases of 9.x are planned AFAIK.

@ofrobots ofrobots closed this Jun 28, 2018
@ofrobots ofrobots deleted the backport/9/806388 branch June 28, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants