[v10.x] src: backport programmatically accessible CLI options #22644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.
PR-URL: nodejs#22490
Reviewed-By: Michaël Zasso <[email protected]>
Instead of having a custom, static, hand-written string that is being printed to stdout when `--help` is present, generate it in JS when requested. PR-URL: nodejs#22490 Reviewed-By: Michaël Zasso <[email protected]>
nodejs-github-bot
added
c++
targos
approved these changes
Sep 1, 2018
mihalskiy
approved these changes
Sep 1, 2018
targos
pushed a commit
that referenced
this pull request
Sep 2, 2018
Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.
Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 2, 2018
Instead of having a custom, static, hand-written string that is being printed to stdout when `--help` is present, generate it in JS when requested. Backport-PR-URL: #22644 PR-URL: #22490 Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.
Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Instead of having a custom, static, hand-written string that is being printed to stdout when `--help` is present, generate it in JS when requested. Backport-PR-URL: #22644 PR-URL: #22490 Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.
Backport-PR-URL: #22644
PR-URL: #22490
Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Instead of having a custom, static, hand-written string that is being printed to stdout when `--help` is present, generate it in JS when requested. Backport-PR-URL: #22644 PR-URL: #22490 Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only conflicts are two more changed lines for
--expose-http2in the first commit and a neighbouring-line conflict innode.gypin the second commit.(Backports #22490)