fs: ensure readdir() callback is only called once #22793
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the readdir() callback can only be called once when the withFileTypes parameter is supplied.
nodejs-github-bot
added
fs
bengl
approved these changes
Sep 11, 2018
apapirovski
approved these changes
Sep 11, 2018
ajafff
approved these changes
Sep 11, 2018
|
This seems like it might also be a candidate for fast-tracking if we’re doing a 10.10.1 release this week (the other one being #22790), right? |
JungMinu
approved these changes
Sep 11, 2018
|
Landed in 466cda0. |
danbev
pushed a commit
that referenced
this pull request
Sep 13, 2018
This commit ensures that the readdir() callback can only be called once when the withFileTypes parameter is supplied. PR-URL: #22793 Fixes: #22778 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 15, 2018
This commit ensures that the readdir() callback can only be called once when the withFileTypes parameter is supplied. PR-URL: #22793 Fixes: #22778 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 19, 2018
This commit ensures that the readdir() callback can only be called once when the withFileTypes parameter is supplied. PR-URL: #22793 Fixes: #22778 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
This commit ensures that the readdir() callback can only be called once when the withFileTypes parameter is supplied. PR-URL: #22793 Fixes: #22778 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the
readdir()callback can only be called once when thewithFileTypesparameter is supplied.Fixes: #22778
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes