Skip to content

test: switch strictEqual parameters - actual first before expected #23537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: switch strictEqual parameters - actual first before expected #23537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/pummel/test-exec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ exec(
console.log(`error!: ${err.code}`);
console.log(`stdout: ${JSON.stringify(stdout)}`);
console.log(`stderr: ${JSON.stringify(stderr)}`);
assert.strictEqual(false, err.killed);
assert.strictEqual(err.killed, false);
} else {
success_count++;
console.dir(stdout);
Expand All @@ -59,11 +59,11 @@ exec(
exec('thisisnotavalidcommand', function(err, stdout, stderr) {
if (err) {
error_count++;
assert.strictEqual('', stdout);
assert.strictEqual(stdout, '');
assert.strictEqual(typeof err.code, 'number');
assert.notStrictEqual(err.code, 0);
assert.strictEqual(false, err.killed);
assert.strictEqual(null, err.signal);
assert.strictEqual(err.killed, false);
assert.strictEqual(err.signal, null);
console.log(`error code: ${err.code}`);
console.log(`stdout: ${JSON.stringify(stdout)}`);
console.log(`stderr: ${JSON.stringify(stderr)}`);
Expand Down Expand Up @@ -97,7 +97,7 @@ process.nextTick(function() {
console.log(`kill pid ${killMeTwice.pid}`);
// make sure there is no race condition in starting the process
// the PID SHOULD exist directly following the exec() call.
assert.strictEqual('number', typeof killMeTwice._handle.pid);
assert.strictEqual(typeof killMeTwice._handle.pid, 'number');
// Kill the process
killMeTwice.kill();
});
Expand Down Expand Up @@ -128,6 +128,6 @@ exec('python -c "print 200000*\'C\'"', { maxBuffer: 1000 },


process.on('exit', function() {
assert.strictEqual(1, success_count);
assert.strictEqual(1, error_count);
assert.strictEqual(success_count, 1);
assert.strictEqual(error_count, 1);
});