test: augment tests for SourceTextModule #23573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
the
code-and-learn
Adds tests for a few error conditions. Also, adds tests to make sure the dynamically generated url is correct.
aeisenberg
force-pushed
the
augment-SourceTextModule-tests
branch
from
b7b416b to
457d81c
Compare
|
I am running |
|
...and the tests all passed locally. |
jasnell
approved these changes
Oct 12, 2018
BridgeAR
approved these changes
Oct 12, 2018
cjihrig
approved these changes
Oct 12, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
Adds tests for a few error conditions. Also, adds tests to make sure the dynamically generated url is correct. PR-URL: nodejs#23573 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: nodejs#23572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 15, 2018
Adds tests for a few error conditions. Also, adds tests to make sure the dynamically generated url is correct. PR-URL: nodejs#23573 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: nodejs#23572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in cac4909 🎉 @aeisenberg congratulations on your commit to Node.js! Seems like I messed up the meta data in this commit. The second part should be ignored. |
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Adds tests for a few error conditions. Also, adds tests to make sure the dynamically generated url is correct. PR-URL: #23573 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #23572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 17, 2019
Adds tests for a few error conditions. Also, adds tests to make sure the dynamically generated url is correct. PR-URL: #23573 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #23572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for a few error conditions. Also, adds tests to make sure
the dynamically generated url is correct.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes