[v10.x backport] src: trace_event: secondary storage for metadata #23700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
3 tasks
ofrobots
force-pushed
the
backport-10-20900
branch
from
36c5e4d to
7659133
Compare
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/17957/ |
|
@nodejs/release do backports need an lgtm before landing? Can I get a review? |
jasnell
approved these changes
Oct 19, 2018
3 tasks
|
Please make sure to have a look at #23947 before landing this :) |
MylesBorins
force-pushed
the
v10.x-staging
branch
from
3f63297 to
8e7a12f
Compare
|
@ofrobots Could this be rebased please? |
Metadata trace-events should be held in secondary storage so that they can be periodically reemitted. This change establishes the secondary storage and ensures that events are reemitted on each flush. PR-URL: nodejs#20900 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: nodejs#23700
PR-URL: nodejs#23947 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
ofrobots
force-pushed
the
backport-10-20900
branch
from
7659133 to
b65e585
Compare
|
Rebased. I also picked up #23947. New CI: https://ci.nodejs.org/job/node-test-pull-request/18418/ |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 12, 2018
Metadata trace-events should be held in secondary storage so that they can be periodically reemitted. This change establishes the secondary storage and ensures that events are reemitted on each flush. Backport-PR-URL: #23700 PR-URL: #20900 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: #23700
MylesBorins
pushed a commit
that referenced
this pull request
Nov 12, 2018
Backport-PR-URL: #23700 PR-URL: #23947 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
|
landed in 3df083c...9a7554a |
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Metadata trace-events should be held in secondary storage so that they can be periodically reemitted. This change establishes the secondary storage and ensures that events are reemitted on each flush. Backport-PR-URL: #23700 PR-URL: #20900 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: #23700
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Backport-PR-URL: #23700 PR-URL: #23947 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Metadata trace-events should be held in secondary storage so that they can be periodically reemitted. This change establishes the secondary storage and ensures that events are reemitted on each flush. Backport-PR-URL: #23700 PR-URL: #20900 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: #23700
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Backport-PR-URL: #23700 PR-URL: #23947 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata trace-events should be held in secondary storage so that they
can be periodically reemitted. This change establishes the secondary
storage and ensures that events are reemitted on each flush.
PR-URL: #20900
Reviewed-By: James M Snell [email protected]
Reviewed-By: Anna Henningsen [email protected]
Backport-PR-URL: #23700
CI: https://ci.nodejs.org/job/node-test-pull-request/17918/Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes