src: zlib: revert concatenated-stream changes #240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but the commit log should explain why it reverts those commits. |
chrisdickinson
added a commit
that referenced
this pull request
Jan 9, 2015
Revert "src: fix windows build error" and "zlib: support concatenated gzip files". This reverts commits be413ac and 1183ba4. Treating subsequent bytes as a concatenated zlib stream breaks npm install. Conflicts: test/parallel/test-zlib-from-multiple-gzip-with-garbage.js test/parallel/test-zlib-from-multiple-gzip.js test/parallel/test-zlib-from-multiple-huge-gzip.js Fixes: nodejs/node-v0.x-archive#8962 PR-URL: #240 Reviewed-By: Ben Noordhuis <[email protected]>
|
Merged in bc629c0. |
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "src: fix windows build error" and "zlib: support
concatenated gzip files".
This reverts commits be413ac
and 1183ba4.
Conflicts:
test/parallel/test-zlib-from-multiple-gzip-with-garbage.js
test/parallel/test-zlib-from-multiple-gzip.js
test/parallel/test-zlib-from-multiple-huge-gzip.js
Fixes: npm errors here. Equivalent Node PR here. If there are no objections I'd like to re-add this behavior behind an option after this is reverted.