Skip to content

doc: add oyyd to collaborators #24300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: add oyyd to collaborators #24300

wants to merge 1 commit into from

Conversation

oyyd
Copy link
Contributor

@oyyd oyyd commented Nov 11, 2018 •
edited
Loading

Add me to collaborators.

/cc @joyeecheung

Fixes: #23955

Checklist

@nodejs-github-bot
Copy link
Collaborator

@oyyd build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1575/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 11, 2018
@oyyd oyyd added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 11, 2018
@oyyd
Copy link
Contributor Author

oyyd commented Nov 11, 2018

The CI building is appending. But it should be okay to land this.

@gireeshpunathil
Copy link
Member

@oyyd - apologies, I initiated a number of CI runs that were part of code&learn PRs, that probably caused your CI to be queued waiting for machines.

I guess the recommended way here is: propose fast-tracking and seek approval from at least 2 collab's. I approve fast-tracking.

@joyeecheung
Copy link
Member

@gireeshpunathil This is an onboarding PR so I guess we don't necessarily need the fast-track thumbs-up process here...I'd say we can just land this as the CI run for this PR is just a formality (and to check that the collaborator can indeed start a CI run)

Although ncu is correctly having trouble validating the status because there is no CI link in this thread (somehow it doesn't recognize the pipeline link posted by the bot - I will open an issue later). @oyyd started a job in Jenkins somehow it mysteriously disappeared before it enters the queue (I saw it was in pending status a while back). Anyway the link should've been https://ci.nodejs.org/job/node-test-pull-request/18529/

@gireeshpunathil
Copy link
Member

@joyeecheung - sure, thanks for the clarification and sorry for any turbulence.

oyyd added a commit that referenced this pull request Nov 11, 2018
@oyyd
doc: add oyyd to collaborators
616125c 
PR-URL: #24300
Fixes: #23955
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@oyyd
Copy link
Contributor Author

oyyd commented Nov 11, 2018 •
edited
Loading

Landed in 616125c. Thanks!

@oyyd oyyd closed this Nov 11, 2018
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@oyyd @BridgeAR
doc: add oyyd to collaborators
991d066 
PR-URL: #24300
Fixes: #23955
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR added a commit that referenced this pull request Nov 14, 2018
@BridgeAR
2018-11-15, Version 11.2.0 (Current)
b0e07c5 
Notable changes:

* child_process:
  * All child processes will again open up a new Window on Windows by
    default. [#24034](#24034)
* deps:
  * A new and fast experimental HTTP parser (`llhttp`) is now supported.
    [#24059](#24059)
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    [#24300](#24300)
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    [#24170](#24170)
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    [#24136](#24136)
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
BridgeAR added a commit that referenced this pull request Nov 14, 2018
@BridgeAR
2018-11-15, Version 11.2.0 (Current)
f410a6d 
Notable changes:

* child_process:
  * All child processes will again open up a new Window on Windows by
    default. [#24034](#24034)
* deps:
  * A new and fast experimental HTTP parser (`llhttp`) is now supported.
    [#24059](#24059)
* **Windows**
  * A crashing process will now show the names of stack frames if the
    node.pdb file is available.
    [#23822](#23822)
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    [#24300](#24300)
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    [#24170](#24170)
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    [#24136](#24136)
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@oyyd @kiyomizumia
doc: add oyyd to collaborators
9bf8309 
PR-URL: nodejs#24300
Fixes: nodejs#23955
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Nov 15, 2018
@BridgeAR @targos
2018-11-15, Version 11.2.0 (Current)
a19e1ab 
Notable changes:

* deps:
  * A new experimental HTTP parser (`llhttp`) is now supported.
    #24059
* timers:
  * Fixed an issue that could cause setTimeout to stop working as
    expected. #24322
* Windows
  * A crashing process will now show the names of stack frames if the
    node.pdb file is available.
    #23822
  * Continued effort to improve the installer's new stage that installs
    native build tools.
    #23987,
    #24348
  * child_process:
    * On Windows the `windowsHide` option default was restored to
      `false`. This means `detached` child processes and GUI apps will
      once again start in a new window.
      #24034
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    #24300
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    #24170
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    #24136
targos pushed a commit that referenced this pull request Nov 15, 2018
@BridgeAR @targos
2018-11-15, Version 11.2.0 (Current)
406d9ca 
Notable changes:

* deps:
  * A new experimental HTTP parser (`llhttp`) is now supported.
    #24059
* timers:
  * Fixed an issue that could cause setTimeout to stop working as
    expected. #24322
* Windows
  * A crashing process will now show the names of stack frames if the
    node.pdb file is available.
    #23822
  * Continued effort to improve the installer's new stage that installs
    native build tools.
    #23987,
    #24348
  * child_process:
    * On Windows the `windowsHide` option default was restored to
      `false`. This means `detached` child processes and GUI apps will
      once again start in a new window.
      #24034
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    #24300
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    #24170
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    #24136

PR-URL: #24350
This was referenced Nov 15, 2018
Closed
Closed
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@oyyd @codebytere
doc: add oyyd to collaborators
e6ae331 
PR-URL: #24300
Fixes: #23955
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@oyyd @MylesBorins
doc: add oyyd to collaborators
c8d2635 
PR-URL: #24300
Fixes: #23955
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
codebytere added a commit that referenced this pull request Jan 4, 2019
@codebytere
2019-01-08, Version 10.15.1 'Dubnium' (LTS)
e38fd64 
Notable changes:

* doc:
  * add oyyd to collaborators (Ouyang Yadong) [#24300](#24300)
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
codebytere added a commit that referenced this pull request Jan 7, 2019
@codebytere
2019-01-08, Version 10.15.1 'Dubnium' (LTS)
3419dc0 
Notable changes:

* doc:
  * add oyyd to collaborators (Ouyang Yadong) [#24300](#24300)
codebytere added a commit that referenced this pull request Jan 15, 2019
@codebytere
2019-01-29, Version 10.15.1 'Dubnium' (LTS)
d3c07bd 
* doc:
  * add oyyd to collaborators (Ouyang Yadong) [#24300](#24300)
codebytere added a commit that referenced this pull request Jan 29, 2019
@codebytere
2019-01-29, Version 10.15.1 'Dubnium' (LTS)
3867ef0 
* doc:
  * add oyyd to collaborators (Ouyang Yadong) [#24300](#24300)
* tls:
  * throw if protocol too long (Andre Jodat-Danbrani) [#23606](#23606)
codebytere added a commit that referenced this pull request Jan 29, 2019
@codebytere
2019-01-29, Version 10.15.1 'Dubnium' (LTS)
d56212e 
* doc:
  * add oyyd to collaborators (Ouyang Yadong) [#24300](#24300)
* tls:
  * throw if protocol too long (Andre Jodat-Danbrani) [#23606](#23606)

PR-URL: #25346
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nominating Ouyang Yadong (oyyd) to be a collaborator

5 participants

@oyyd @nodejs-github-bot @gireeshpunathil @joyeecheung @addaleax