Skip to content

src: replace create new Array #24618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: replace create new Array #24618

wants to merge 1 commit into from

Conversation

koh110
Copy link
Contributor

@koh110 koh110 commented Nov 24, 2018

Checklist

replace Array::New(size) to new API on v8.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 24, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@hiroppy hiroppy added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 24, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18950/

@Trott
Copy link
Member

Trott commented Nov 29, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/19015/

@gireeshpunathil
Copy link
Member

landed as 1dfa1a2 , thanks!

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Nov 29, 2018
@koh110 @gireeshpunathil
src: replace create new Array
1dfa1a2 
PR-URL: nodejs#24618
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
targos pushed a commit that referenced this pull request Nov 29, 2018
@koh110 @targos
src: replace create new Array
b554ff7 
PR-URL: #24618
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
@koh110 koh110 deleted the v8_depricate_serdes branch November 30, 2018 07:52
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@koh110 @refack
src: replace create new Array
fc6c372 
PR-URL: nodejs#24618
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+3 more reviewers

@Leko Leko Leko approved these changes

@devsnek devsnek devsnek approved these changes

@shisama shisama shisama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@koh110 @gireeshpunathil @Trott @addaleax @Leko @devsnek @shisama @hiroppy @BethGriggs @nodejs-github-bot