test: fix and refactor test-fs-watch-non-recursive #25386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if it were a built-in and was failing because of it. Fix the path. The test now works.
The test was duplicating some functionality in the `tmpdir` module.
|
pummel tests are not run in CI, so lite CI should be sufficient |
cjihrig
approved these changes
Jan 8, 2019
richardlau
approved these changes
Jan 8, 2019
jasnell
approved these changes
Jan 8, 2019
Trott
added
the
author ready
|
Landed in e18b461...fa5af0d |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 10, 2019
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if it were a built-in and was failing because of it. Fix the path. The test now works. PR-URL: nodejs#25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 10, 2019
The test was duplicating some functionality in the `tmpdir` module. PR-URL: nodejs#25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if it were a built-in and was failing because of it. Fix the path. The test now works. PR-URL: #25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jan 14, 2019
The test was duplicating some functionality in the `tmpdir` module. PR-URL: #25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if it were a built-in and was failing because of it. Fix the path. The test now works. PR-URL: nodejs#25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
The test was duplicating some functionality in the `tmpdir` module. PR-URL: nodejs#25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if it were a built-in and was failing because of it. Fix the path. The test now works. PR-URL: #25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
The test was duplicating some functionality in the `tmpdir` module. PR-URL: #25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if it were a built-in and was failing because of it. Fix the path. The test now works. PR-URL: #25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
The test was duplicating some functionality in the `tmpdir` module. PR-URL: #25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
test-fs-watch-non-recursive was loading the `common/tmpdir` module as if it were a built-in and was failing because of it. Fix the path. The test now works. PR-URL: #25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
The test was duplicating some functionality in the `tmpdir` module. PR-URL: #25386 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-fs-watch-non-recursive was loading the
common/tmpdirmodule as ifit were a built-in and was failing because of it. Fix the path. The test
now works.
The test was duplicating some functionality in the
tmpdirmodule. Usetmpdirmodule instead.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes