src: silence compiler warning in node_report.cc #25557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the following compiler warnings is generated:
../src/node_report.cc:778:43:
warning: format specifies type 'unsigned long' but the argument has
type 'rlim_t' (aka 'unsigned long long') [-Wformat]
snprintf(buf, sizeof(buf), "%lu", limit.rlim_max);
~~~ ^~~~~~~~~~~~~~
%llu
1 warning generated.
This commit changes the format specifier to $llu.
nodejs-github-bot
added
the
c++
gireeshpunathil
approved these changes
Jan 18, 2019
|
Please give a 👍 if you think this can be fast-tracked or if you disagree then please remove the |
richardlau
approved these changes
Jan 18, 2019
JungMinu
approved these changes
Jan 18, 2019
|
Landed in 20fdcad. |
danbev
added a commit
that referenced
this pull request
Jan 18, 2019
Currently the following compiler warnings is generated:
../src/node_report.cc:778:43:
warning: format specifies type 'unsigned long' but the argument has
type 'rlim_t' (aka 'unsigned long long') [-Wformat]
snprintf(buf, sizeof(buf), "%lu", limit.rlim_max);
~~~ ^~~~~~~~~~~~~~
%llu
1 warning generated.
This commit changes the format specifier to $llu.
PR-URL: #25557
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 24, 2019
Currently the following compiler warnings is generated:
../src/node_report.cc:778:43:
warning: format specifies type 'unsigned long' but the argument has
type 'rlim_t' (aka 'unsigned long long') [-Wformat]
snprintf(buf, sizeof(buf), "%lu", limit.rlim_max);
~~~ ^~~~~~~~~~~~~~
%llu
1 warning generated.
This commit changes the format specifier to $llu.
PR-URL: #25557
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the following compiler warnings is generated:
This commit changes the format specifier to $llu.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes