[v8.x] deps: V8: cherry-pick 3cc6919 #25874
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
v8 engine
|
V8 version on master already includes this fix, backporting it to v8.x. A separate PR has been created for backporting it to v10.x: #25872 |
richardlau
approved these changes
Feb 1, 2019
richardlau
changed the title
gdams
approved these changes
Feb 2, 2019
BethGriggs
approved these changes
Feb 5, 2019
Original commit message:
PPC: fix Regex addi overflow
using add insetad of addi when Operand is more than 16 bits long
Change-Id: I7f9452381ed8b321ec71e68d0d90485508b69885
Reviewed-on: https://chromium-review.googlesource.com/c/1430619
Commit-Queue: Junliang Yan <[email protected]>
Reviewed-by: Junliang Yan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#59049}
Refs: v8/v8@3cc6919
BethGriggs
pushed a commit
that referenced
this pull request
Mar 21, 2019
Original commit message:
PPC: fix Regex addi overflow
using add insetad of addi when Operand is more than 16 bits long
Change-Id: I7f9452381ed8b321ec71e68d0d90485508b69885
Reviewed-on: https://chromium-review.googlesource.com/c/1430619
Commit-Queue: Junliang Yan <[email protected]>
Reviewed-by: Junliang Yan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#59049}
Refs: v8/v8@3cc6919
PR-URL: #25874
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
|
Landed on v8.x-staging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@3cc6919
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes